libcli/smb: only allow SMB2_LEASE_FLAG_PARENT_LEASE_KEY_SET in lease_flag

MS-SMB2 3.3.5.9.11 Handling the SMB2_CREATE_REQUEST_LEASE_V2 Create Context:

  The server MUST attempt to locate a Lease by performing a lookup in the
  LeaseTable.LeaseList using the LeaseKey ...

  If no lease is found, one MUST be allocated with the following values set:

  ...

  * Lease.Breaking is set to FALSE.

  ...

Ensures we ignore SMB2_LEASE_FLAG_BREAK_IN_PROGRESS. Found by
MS-SMB2-Prototocol-Testsuite "BreakReadLeaseV2TestCaseS0".

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/libcli/smb/smb2_lease.c b/libcli/smb/smb2_lease.c
index 630fd3943cc3c5b320a5e4c988f723d08206113f..442bdc600216ce58bbe71cb77e0d3ac03a808437 100644 (file)
--- a/libcli/smb/smb2_lease.c
+++ b/libcli/smb/smb2_lease.c
@@ -54,6 +54,7 @@ ssize_t smb2_lease_pull(const uint8_t *buf, size_t len,
        case 2:
                memcpy(&lease->parent_lease_key, buf+32, 16);
                lease->lease_flags = IVAL(buf, 20);
+               lease->lease_flags &= SMB2_LEASE_FLAG_PARENT_LEASE_KEY_SET;
                lease->lease_duration = BVAL(buf, 24);
                lease->lease_epoch = SVAL(buf, 48);
                break;

diff --git a/selftest/knownfail.d/samba3.smb2.lease b/selftest/knownfail.d/samba3.smb2.lease
deleted file mode 100644 (file)
index c29d81a..0000000
--- a/selftest/knownfail.d/samba3.smb2.lease
+++ /dev/null
@@ -1 +0,0 @@
-^samba3.smb2.lease.v2_flags_breaking\(fileserver\)