]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_driver: Fix virDomainSaveImageDefineXML
authorPavel Hrdina <phrdina@redhat.com>
Mon, 24 Mar 2025 19:11:58 +0000 (20:11 +0100)
committerPavel Hrdina <phrdina@redhat.com>
Tue, 25 Mar 2025 11:50:30 +0000 (12:50 +0100)
Commit 28a06215280b99708ed8dc2d183f62ba7b34ccf8 added support to restore
sparse images but changed the boolean that controls if we open the file
as read-only or read-write. Editing XML in the save image resulted in
following error message:

    failed to write header to domain save file '/data/images/fedora40.save': Bad file descriptor

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
Reviewed-by: Jim Fehlig <jfehlig@suse.com>
src/qemu/qemu_driver.c

index 1be32c01b1fcfc1348fd4b6f68749c2db9580567..6ce949dd07402532ab393d3ed94bd175cfc864eb 100644 (file)
@@ -5948,7 +5948,7 @@ qemuDomainSaveImageDefineXML(virConnectPtr conn, const char *path,
     if (qemuSaveImageGetMetadata(driver, NULL, path, &def, &data) < 0)
         goto cleanup;
 
-    fd = qemuSaveImageOpen(driver, path, false, false, NULL, false);
+    fd = qemuSaveImageOpen(driver, path, false, false, NULL, true);
 
     if (fd < 0)
         goto cleanup;