]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net/mlx5: HWS: Fix memory leak in mlx5hws_definer_calc_layout
authorCosmin Ratiu <cratiu@nvidia.com>
Tue, 3 Dec 2024 20:49:15 +0000 (22:49 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Dec 2024 03:43:45 +0000 (19:43 -0800)
It allocates a match template, which creates a compressed definer fc
struct, but that is not deallocated.

This commit fixes that.

Fixes: 74a778b4a63f ("net/mlx5: HWS, added definers handling")
Signed-off-by: Cosmin Ratiu <cratiu@nvidia.com>
Reviewed-by: Yevgeny Kliteynik <kliteyn@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/20241203204920.232744-2-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/steering/hws/bwc_complex.c

index c00010ca86bdc16798c70630944e8da6e7f7cfc5..9fb059a6511f7f99cd7944241f6a389097420b3e 100644 (file)
@@ -39,6 +39,8 @@ bool mlx5hws_bwc_match_params_is_complex(struct mlx5hws_context *ctx,
                } else {
                        mlx5hws_err(ctx, "Failed to calculate matcher definer layout\n");
                }
+       } else {
+               kfree(mt->fc);
        }
 
        mlx5hws_match_template_destroy(mt);