]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
f2fs: remove unnecessary null checking
authorKohei Enju <enjuk@amazon.com>
Sun, 2 Feb 2025 04:32:53 +0000 (13:32 +0900)
committerJaegeuk Kim <jaegeuk@kernel.org>
Thu, 6 Feb 2025 18:34:43 +0000 (18:34 +0000)
When __GFP_DIRECT_RECLAIM (included in both GFP_NOIO and GFP_KERNEL) is
specified, bio_alloc_bioset() never fails to allocate a bio.
Commit 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO") replaced
f2fs_bio_alloc() with bio_alloc_bioset(), but null checking after
bio_alloc_bioset() was still left.

Fixes: 67883ade7a98 ("f2fs: remove FAULT_ALLOC_BIO")
Signed-off-by: Kohei Enju <enjuk@amazon.com>
Reviewed-by: Jens Axboe <axboe@kernel.dk>
Reviewed-by: Chao Yu <chao@kernel.org>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
fs/f2fs/data.c

index de4da6d9cd93a7d7e73a470909578697b6e7ca11..07b46b444d3181291121c932b86372237ace8287 100644 (file)
@@ -1041,8 +1041,6 @@ static struct bio *f2fs_grab_read_bio(struct inode *inode, block_t blkaddr,
        bio = bio_alloc_bioset(bdev, bio_max_segs(nr_pages),
                               REQ_OP_READ | op_flag,
                               for_write ? GFP_NOIO : GFP_KERNEL, &f2fs_bioset);
-       if (!bio)
-               return ERR_PTR(-ENOMEM);
        bio->bi_iter.bi_sector = sector;
        f2fs_set_bio_crypt_ctx(bio, inode, first_idx, NULL, GFP_NOFS);
        bio->bi_end_io = f2fs_read_end_io;