]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
intel_th: Output devices without ports don't need assigning
authorAlexander Shishkin <alexander.shishkin@linux.intel.com>
Fri, 18 Nov 2016 12:51:05 +0000 (14:51 +0200)
committerAlexander Shishkin <alexander.shishkin@linux.intel.com>
Fri, 25 Aug 2017 14:58:35 +0000 (17:58 +0300)
Output subdevices that rely on other output subdevices (or otherwise
don't directly talk to an output port on the switch) don't need to be
assigned an output port either.

Signed-off-by: Alexander Shishkin <alexander.shishkin@linux.intel.com>
drivers/hwtracing/intel_th/intel_th.h

index 3096e7054f6dba9388690cd022fd8730029587c8..c03f28ef6409f5df5d045eec36be199a915cb1aa 100644 (file)
@@ -96,6 +96,16 @@ intel_th_device_get_resource(struct intel_th_device *thdev, unsigned int type,
        return NULL;
 }
 
+/*
+ * GTH, output ports configuration
+ */
+enum {
+       GTH_NONE = 0,
+       GTH_MSU,        /* memory/usb */
+       GTH_CTP,        /* Common Trace Port */
+       GTH_PTI = 4,    /* MIPI-PTI */
+};
+
 /**
  * intel_th_output_assigned() - if an output device is assigned to a switch port
  * @thdev:     the output device
@@ -106,7 +116,8 @@ static inline bool
 intel_th_output_assigned(struct intel_th_device *thdev)
 {
        return thdev->type == INTEL_TH_OUTPUT &&
-               thdev->output.port >= 0;
+               (thdev->output.port >= 0 ||
+                thdev->output.type == GTH_NONE);
 }
 
 /**
@@ -249,16 +260,6 @@ enum {
        REG_DCIH_LENGTH         = REG_MSU_LENGTH,
 };
 
-/*
- * GTH, output ports configuration
- */
-enum {
-       GTH_NONE = 0,
-       GTH_MSU,        /* memory/usb */
-       GTH_CTP,        /* Common Trace Port */
-       GTH_PTI = 4,    /* MIPI-PTI */
-};
-
 /*
  * Scratchpad bits: tell firmware and external debuggers
  * what we are up to.