]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: staging: ipu3-imgu: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:15:11 +0000 (14:15 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:16 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./ipu3/ipu3.c:534:5-12: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/staging/media/ipu3/ipu3.c

index e22a9c0921957ef2fbf7b8a11fab28e6d78c60eb..bdf5a457752b24bf35e38491d63fc1e059a1e058 100644 (file)
@@ -530,8 +530,7 @@ static irqreturn_t imgu_isr_threaded(int irq, void *imgu_ptr)
                if (IS_ERR(b)) {
                        if (PTR_ERR(b) != -EBUSY)       /* All done */
                                dev_err(&imgu->pci_dev->dev,
-                                       "failed to dequeue buffers (%ld)\n",
-                                       PTR_ERR(b));
+                                       "failed to dequeue buffers (%pe)\n", b);
                        break;
                }