CLEANUP: http-ana: Remove useless test on txn when the error message is retrieved

In http_error_message(), the HTTP txn is always defined. So, this is no reason
to test its nullity.

This patch partially fixes the issue #457.

diff --git a/src/http_ana.c b/src/http_ana.c
index 82a9e14a26ad93a6b935b7179e361ea7d3ca94f2..23db04ece5941526746bc559d839a2a57566abaf 100644 (file)
--- a/src/http_ana.c
+++ b/src/http_ana.c
@@ -4603,7 +4603,7 @@ struct buffer *http_error_message(struct stream *s)
 {
        const int msgnum = http_get_status_idx(s->txn->status);
 
-       if (s->txn && s->txn->errmsg)
+       if (s->txn->errmsg)
                return s->txn->errmsg;
        else if (s->be->errmsg[msgnum])
                return s->be->errmsg[msgnum];