]> git.ipfire.org Git - thirdparty/lxc.git/commitdiff
rmdir and lxc_unpriv returns non-negative error codes
authorS.Çağlar Onur <caglar@10ur.org>
Thu, 4 Dec 2014 17:59:47 +0000 (12:59 -0500)
committerStéphane Graber <stgraber@ubuntu.com>
Thu, 4 Dec 2014 20:30:01 +0000 (15:30 -0500)
Signed-off-by: S.Çağlar Onur <caglar@10ur.org>
Acked-by: Stéphane Graber <stgraber@ubuntu.com>
src/lxc/bdev.c
src/lxc/log.c

index 9ccd666597dc5320ed73089d539a2f6580c87b14..9d0a735f73ab3e2403c245eb6ad41c696d0a0547 100644 (file)
@@ -1418,7 +1418,7 @@ static int btrfs_snapshot(const char *orig, const char *new)
                goto out;
        }
        // make sure the directory doesn't already exist
-       if (rmdir(newfull) < 0 && errno != -ENOENT) {
+       if (rmdir(newfull) < 0 && errno != ENOENT) {
                SYSERROR("Error removing empty new rootfs");
                goto out;
        }
@@ -1511,7 +1511,7 @@ static int btrfs_clonepaths(struct bdev *orig, struct bdev *new, const char *old
                return userns_exec_1(conf, btrfs_snapshot_wrapper, &sdata);
        }
 
-       if (rmdir(new->dest) < 0 && errno != -ENOENT) {
+       if (rmdir(new->dest) < 0 && errno != ENOENT) {
                SYSERROR("removing %s", new->dest);
                return -1;
        }
index cb48600a7e9e348d108c056788b2245aec4dd0ac..13bd0e8f2898c4ddd088f58b9e40e75d203a1c5a 100644 (file)
@@ -159,7 +159,7 @@ static int build_dir(const char *name)
                *p = '\0';
                if (access(n, F_OK)) {
                        ret = lxc_unpriv(mkdir(n, 0755));
-                       if (ret && errno != -EEXIST) {
+                       if (ret && errno != EEXIST) {
                                SYSERROR("failed to create directory '%s'.", n);
                                free(n);
                                return -1;