]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
smb/client: avoid null-ptr-deref when tests fail in test_cmp_map()
authorSunJianHao <24031212195@stu.xidian.edu.cn>
Fri, 3 Apr 2026 13:12:05 +0000 (21:12 +0800)
committerSteve French <stfrench@microsoft.com>
Mon, 6 Apr 2026 00:58:40 +0000 (19:58 -0500)
Use KUNIT_ASSERT_NOT_NULL() to abort the test cases on failure.

Reported-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: SunJianHao <24031212195@stu.xidian.edu.cn>
Reviewed-by: ChenXiaoSong <chenxiaosong@kylinos.cn>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/smb2maperror_test.c

index 8c47dea7a2c11cfa0cf49b532c4d62f1b35f9359..8c4f168c8e9956d54242ce2acb748f6da83297e2 100644 (file)
@@ -21,7 +21,7 @@ test_cmp_map(struct kunit *test, const struct status_to_posix_error *expect)
        const struct status_to_posix_error *result;
 
        result = smb2_get_err_map_test(expect->smb2_status);
-       KUNIT_EXPECT_PTR_NE(test, NULL, result);
+       KUNIT_ASSERT_NOT_NULL(test, result);
        KUNIT_EXPECT_EQ(test, expect->smb2_status, result->smb2_status);
        KUNIT_EXPECT_EQ(test, expect->posix_error, result->posix_error);
        KUNIT_EXPECT_STREQ(test, expect->status_string, result->status_string);