]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: imx8mq-mipi-csi2: Use %pe format specifier
authorRicardo Ribalda <ribalda@chromium.org>
Mon, 13 Oct 2025 14:15:05 +0000 (14:15 +0000)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:16 +0000 (11:31 +0200)
The %pe format specifier is designed to print error pointers. It prints
a symbolic error name (eg. -EINVAL) and it makes the code simpler by
omitting PTR_ERR().

This patch fixes this cocci report:
./platform/nxp/imx8mq-mipi-csi2.c:422:23-30: WARNING: Consider using %pe to print PTR_ERR()

Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Reviewed-by: Martin Kepplinger-Novakovic <martink@posteo.de>
Acked-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/nxp/imx8mq-mipi-csi2.c

index 3a4645f59a44028fdca82a4d8393e1a0a6ba88f0..d333ff43539f061b8b9cf88af2cda8c44b3ec2a9 100644 (file)
@@ -418,8 +418,8 @@ static int imx8mq_mipi_csi_calc_hs_settle(struct csi_state *state,
 
        src_pad = media_entity_remote_source_pad_unique(&sd_state->sd->entity);
        if (IS_ERR(src_pad)) {
-               dev_err(state->dev, "can't get source pad of %s (%ld)\n",
-                       sd_state->sd->name, PTR_ERR(src_pad));
+               dev_err(state->dev, "can't get source pad of %s (%pe)\n",
+                       sd_state->sd->name, src_pad);
                return PTR_ERR(src_pad);
        }