]> git.ipfire.org Git - thirdparty/shadow.git/commitdiff
contrib/adduser.c: main(): Use strcpy/cat(3) instead of their pattern
authorAlejandro Colomar <alx@kernel.org>
Sun, 19 May 2024 00:05:16 +0000 (02:05 +0200)
committerSerge Hallyn <serge@hallyn.com>
Wed, 3 Jul 2024 15:03:12 +0000 (10:03 -0500)
Signed-off-by: Alejandro Colomar <alx@kernel.org>
contrib/adduser.c

index c1c9b9d3d54a671e798d489c2259acf1e177bb98..444f8d6ec8b8b0c6d5005662b96da7caa9d96c61 100644 (file)
 #include <sys/stat.h>
 #include <syslog.h>
 
+
 #define IMMEDIATE_CHANGE       /* Expire newly created password, must be changed
                                 * immediately upon next login */
 #define HAVE_QUOTAS            /* Obvious */
@@ -291,12 +292,10 @@ main (void)
          printf ("Home Directory [%s/%s]: ", DEFAULT_HOME, usrname);
          fflush (stdout);
          safeget (dir, sizeof (dir));
-         if (!strlen (dir))
-           {                   /* hit return */
-             sprintf (dir, "%s/%s", DEFAULT_HOME, usrname);
-           }
+         if (!strlen(dir))  /* hit return */
+           sprintf(dir, "%s/%s", DEFAULT_HOME, usrname);
          else if (dir[strlen (dir) - 1] == '/')
-           sprintf (dir+strlen(dir), "%s", usrname);
+           strcat(dir, usrname);
        }
       else
        {
@@ -308,7 +307,7 @@ main (void)
       fflush (stdout);
       safeget (shell, sizeof (shell));
       if (!strlen (shell))
-       sprintf (shell, "%s", DEFAULT_SHELL);
+       strcpy(shell, DEFAULT_SHELL);
       else
        {
          char *sh;
@@ -327,7 +326,7 @@ main (void)
              else
                {
                  printf ("Shell NOT in /etc/shells, DEFAULT used\n");
-                 sprintf (shell, "%s", DEFAULT_SHELL);
+                 strcpy(shell, DEFAULT_SHELL);
                }
            }
        }