hwmon: (emc2305) fix double put in emc2305_probe_childs_from_dt

./drivers/hwmon/emc2305.c:597:4-15: ERROR: probable double put

Device node iterators put the previous value of the index variable, so an
explicit put causes a double put.

Signed-off-by: Pei Xiao <xiaopei01@kylinos.cn>
Link: https://lore.kernel.org/r/tencent_CD373F952BE48697C949E39CB5EB77841D06@qq.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>

diff --git a/drivers/hwmon/emc2305.c b/drivers/hwmon/emc2305.c
index 60809289f8169d685a98305fa017339f69ac97d3..b0f2318c97e333e82ecfa99722f3b7368b878681 100644 (file)
--- a/drivers/hwmon/emc2305.c
+++ b/drivers/hwmon/emc2305.c
@@ -593,10 +593,8 @@ static int emc2305_probe_childs_from_dt(struct device *dev)
        for_each_child_of_node(dev->of_node, child) {
                if (of_property_present(child, "reg")) {
                        ret = emc2305_of_parse_pwm_child(dev, child, data);
-                       if (ret) {
-                               of_node_put(child);
+                       if (ret)
                                continue;
-                       }
                        count++;
                }
        }