]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Coresight: Fix a NULL vs IS_ERR() bug in probe
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 14 Mar 2025 10:55:10 +0000 (13:55 +0300)
committerSuzuki K Poulose <suzuki.poulose@arm.com>
Fri, 14 Mar 2025 12:43:53 +0000 (12:43 +0000)
The devm_platform_get_and_ioremap_resource() function doesn't
return NULL, it returns error pointers.  Update the checking to
match.

Fixes: f78d206f3d73 ("Coresight: Add Coresight TMC Control Unit driver")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Link: https://lore.kernel.org/r/dab039b9-d58a-41be-92f0-ff209cfabfe2@stanley.mountain
drivers/hwtracing/coresight/coresight-ctcu-core.c

index da35d8b4d5798cc704210cad21a26444bfc54999..c6bafc96db963310b5e77a095953c83a172cfc7c 100644 (file)
@@ -204,8 +204,8 @@ static int ctcu_probe(struct platform_device *pdev)
        dev->platform_data = pdata;
 
        base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
-       if (!base)
-               return -ENOMEM;
+       if (IS_ERR(base))
+               return PTR_ERR(base);
 
        drvdata->apb_clk = coresight_get_enable_apb_pclk(dev);
        if (IS_ERR(drvdata->apb_clk))