]> git.ipfire.org Git - thirdparty/openvpn.git/commitdiff
networking_iproute2: don't pass M_WARN to openvpn_execve_check()
authorAntonio Quartulli <a@unstable.cc>
Thu, 7 Apr 2022 20:14:11 +0000 (22:14 +0200)
committerGert Doering <gert@greenie.muc.de>
Fri, 8 Apr 2022 05:54:01 +0000 (07:54 +0200)
openvpn_execve_check() expects a set of flags as third argument and not
a loglevel. For this reason, if no FATAL behaviour is expected, we
should simply pass 0. openvpn_execve_check() will then pick the
appropriate loglevel on its own.

Signed-off-by: Antonio Quartulli <a@unstable.cc>
Acked-by: Gert Doering <gert@greenie.muc.de>
Message-Id: <20220407201411.22486-1-a@unstable.cc>
URL: https://www.mail-archive.com/openvpn-devel@lists.sourceforge.net/msg24090.html
Signed-off-by: Gert Doering <gert@greenie.muc.de>
src/openvpn/networking_iproute2.c

index 3ca2bb35c31a5259c0911e9d0f77dd9e65e646bd..db0f5503b298d6148fd9a5bce2ac40675bfaea4f 100644 (file)
@@ -105,7 +105,7 @@ net_addr_ll_set(openvpn_net_ctx_t *ctx, const openvpn_net_iface_t *iface,
                 iproute_path, MAC_PRINT_ARG(addr), iface);
 
     argv_msg(M_INFO, &argv);
-    if (!openvpn_execve_check(&argv, ctx->es, M_WARN,
+    if (!openvpn_execve_check(&argv, ctx->es, 0,
                               "Linux ip link set addr failed"))
     {
         ret = -1;