t9819: don't use test_must_fail with p4

We were using `test_must_fail p4` to test that the p4 command failed as
expected. However, test_must_fail() is used to ensure that commands fail
in an expected way, not due to something like a segv. Since we are not
in the business of verifying the sanity of the external world, replace
`test_must_fail p4` with `! p4` and assume that the `p4` command does
not die unexpectedly.

Signed-off-by: Denton Liu <liu.denton@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>

diff --git a/t/t9819-git-p4-case-folding.sh b/t/t9819-git-p4-case-folding.sh
index 600ce1e0b0d7edf193291a6a25450c92a5888475..b4d93f0c17c35722184d09d354556e59fef8a2b4 100755 (executable)
--- a/t/t9819-git-p4-case-folding.sh
+++ b/t/t9819-git-p4-case-folding.sh
@@ -30,7 +30,7 @@ test_expect_success 'Check p4 is in case-folding mode' '
                cd "$cli" &&
                >lc/FILE.TXT &&
                p4 add lc/FILE.TXT &&
-               test_must_fail p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT
+               ! p4 submit -d "Cannot add file differing only in case" lc/FILE.TXT
        )
 '