ACPICA: acpidump: fix return values in ap_is_valid_checksum()

The function ap_is_valid_checksum() has a boolean name suggesting it
should return TRUE/FALSE, but incorrectly returns AE_OK on success and
has no explicit return on failure, leading to undefined behavior.

Fix by returning proper values:
 - FALSE when checksum validation fails
 - TRUE when checksum validation succeeds

Link: https://github.com/acpica/acpica/commit/479ba862
Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

diff --git a/tools/power/acpi/tools/acpidump/apdump.c b/tools/power/acpi/tools/acpidump/apdump.c
index bf30143efbdcb18b3bf95f49a4e33a52a5c021e3..7a6223aa703c39ae313c4f12a3a833b91cb08e75 100644 (file)
--- a/tools/power/acpi/tools/acpidump/apdump.c
+++ b/tools/power/acpi/tools/acpidump/apdump.c
@@ -86,9 +86,10 @@ u8 ap_is_valid_checksum(struct acpi_table_header *table)
        if (ACPI_FAILURE(status)) {
                fprintf(stderr, "%4.4s: Warning: wrong checksum in table\n",
                        table->signature);
+               return (FALSE);
        }
 
-       return (AE_OK);
+       return (TRUE);
 }
 
 /******************************************************************************