]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
wifi: ath12k: Fix double budget decrement while reaping monitor ring
authorP Praneesh <praneesh.p@oss.qualcomm.com>
Tue, 3 Jun 2025 10:35:42 +0000 (16:05 +0530)
committerJeff Johnson <jeff.johnson@oss.qualcomm.com>
Mon, 23 Jun 2025 14:28:34 +0000 (07:28 -0700)
Currently, the budget for monitor ring is reduced during each ring entry
reaping and again when the end reason is HAL_MON_END_OF_PPDU, leading to
inefficient budget use. The below mentioned commit intended to decrement
the budget only for HAL_MON_END_OF_PPDU but did not remove the other
decrement. Fix this by eliminating the budget decrement for each ring entry
reaping, ensuring the driver always reaps one full PPDU worth of entries
from the monitor destination ring.

Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1
Tested-on: WCN7850 hw2.0 PCI WLAN.HMT.1.0.c5-00481-QCAHMTSWPL_V1.0_V2.0_SILICONZ-3

Fixes: 394a3fa7c538 ("wifi: ath12k: Optimize NAPI budget by adjusting PPDU processing")
Signed-off-by: P Praneesh <praneesh.p@oss.qualcomm.com>
Reviewed-by: Vasanthakumar Thiagarajan <vasanthakumar.thiagarajan@oss.qualcomm.com>
Link: https://patch.msgid.link/20250603103542.1164713-1-praneesh.p@oss.qualcomm.com
Signed-off-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
drivers/net/wireless/ath/ath12k/dp_mon.c

index 28cadc4167f7875e56eb80407b35cb97d4b19ad2..91f4e3aff74c3804188af69fd9bb81103dc88175 100644 (file)
@@ -3761,7 +3761,6 @@ int ath12k_dp_mon_srng_process(struct ath12k *ar, int *budget,
        ath12k_hal_srng_access_begin(ab, srng);
 
        while (likely(*budget)) {
-               *budget -= 1;
                mon_dst_desc = ath12k_hal_srng_dst_peek(ab, srng);
                if (unlikely(!mon_dst_desc))
                        break;