]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/i915/guc/slpc: Add helper function slpc_measure_power
authorSk Anirban <sk.anirban@intel.com>
Mon, 13 Jan 2025 09:59:12 +0000 (15:29 +0530)
committerAndi Shyti <andi.shyti@linux.intel.com>
Tue, 28 Jan 2025 20:11:24 +0000 (21:11 +0100)
Previously, the RPS function was being used, which utilizes
raw frequency to calculate measured power. This commit introduces
a dedicated function specifically for measuring power in SLPC,
ensuring more accurate and reliable power measurements.

Signed-off-by: Sk Anirban <sk.anirban@intel.com>
Reviewed-by: Badal Nilawar <badal.nilawar@intel.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andi Shyti <andi.shyti@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250113095912.356147-3-sk.anirban@intel.com
drivers/gpu/drm/i915/gt/selftest_slpc.c

index 4ecc4ae74a54c4b2e1f4a32954fea8e582a082cc..cb5d5e2c5dbe11cc95364ab505588106726fcc75 100644 (file)
@@ -95,6 +95,21 @@ static int slpc_restore_freq(struct intel_guc_slpc *slpc, u32 min, u32 max)
        return 0;
 }
 
+static u64 slpc_measure_power(struct intel_rps *rps, int *freq)
+{
+       u64 x[5];
+       int i;
+
+       for (i = 0; i < 5; i++)
+               x[i] = __measure_power(5);
+
+       *freq = (*freq + intel_rps_read_actual_frequency(rps)) / 2;
+
+       /* A simple triangle filter for better result stability */
+       sort(x, 5, sizeof(*x), cmp_u64, NULL);
+       return div_u64(x[1] + 2 * x[2] + x[3], 4);
+}
+
 static u64 measure_power_at_freq(struct intel_gt *gt, int *freq, u64 *power)
 {
        int err = 0;
@@ -103,7 +118,7 @@ static u64 measure_power_at_freq(struct intel_gt *gt, int *freq, u64 *power)
        if (err)
                return err;
        *freq = intel_rps_read_actual_frequency(&gt->rps);
-       *power = measure_power(&gt->rps, freq);
+       *power = slpc_measure_power(&gt->rps, freq);
 
        return err;
 }