]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: s5c73m3: Use the v4l2 helper for obtaining the clock
authorMehdi Djait <mehdi.djait@linux.intel.com>
Thu, 26 Jun 2025 13:34:33 +0000 (15:34 +0200)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Wed, 13 Aug 2025 13:10:27 +0000 (15:10 +0200)
devm_clk_get() fails on ACPI-based platforms, where firmware does not
provide a direct reference to the clock producer.

Replace devm_clk_get() with the new v4l2 helper
devm_v4l2_sensor_clk_get() that works on both DT- and ACPI-based
platforms to retrieve a reference to the clock producer from firmware.

Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Mehdi Djait <mehdi.djait@linux.intel.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/i2c/s5c73m3/s5c73m3-core.c

index 7716dfe2b8c9e04d03e50bd726a98f7fc11fc670..088184da5dea4c0c81bb314c69713dbbacb004e2 100644 (file)
@@ -1556,9 +1556,11 @@ static int s5c73m3_get_dt_data(struct s5c73m3 *state)
        if (!node)
                return -EINVAL;
 
-       state->clock = devm_clk_get(dev, S5C73M3_CLK_NAME);
+       state->clock = devm_v4l2_sensor_clk_get(dev, S5C73M3_CLK_NAME);
        if (IS_ERR(state->clock))
-               return PTR_ERR(state->clock);
+               return dev_err_probe(dev, PTR_ERR(state->clock),
+                                    "Failed to get the clock %s\n",
+                                    S5C73M3_CLK_NAME);
 
        if (of_property_read_u32(node, "clock-frequency",
                                 &state->mclk_frequency)) {