crypto: ccree - no need to check return value of debugfs_create functions

When calling debugfs functions, there is no need to ever check the
return value.  The function can work or not, but the code logic should
never do something different based on this.

Cc: Yael Chemla <yael.chemla@foss.arm.com>
Cc: Gilad Ben-Yossef <gilad@benyossef.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: linux-crypto@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Acked-By: Gilad Ben-Yossef <gilad@benyossef.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

diff --git a/drivers/crypto/ccree/cc_debugfs.c b/drivers/crypto/ccree/cc_debugfs.c
index 5ca184e4248350e59bd9abb8551241c7cf27d297..5fa05a7bcf3647dfed2557963fe4a26410ec2eb4 100644 (file)
--- a/drivers/crypto/ccree/cc_debugfs.c
+++ b/drivers/crypto/ccree/cc_debugfs.c
@@ -39,11 +39,9 @@ static struct debugfs_reg32 debug_regs[] = {
        CC_DEBUG_REG(AXIM_MON_COMP),
 };
 
-int __init cc_debugfs_global_init(void)
+void __init cc_debugfs_global_init(void)
 {
        cc_debugfs_dir = debugfs_create_dir("ccree", NULL);
-
-       return !cc_debugfs_dir;
 }
 
 void __exit cc_debugfs_global_fini(void)
@@ -56,7 +54,6 @@ int cc_debugfs_init(struct cc_drvdata *drvdata)
        struct device *dev = drvdata_to_dev(drvdata);
        struct cc_debugfs_ctx *ctx;
        struct debugfs_regset32 *regset;
-       struct dentry *file;
 
        debug_regs[0].offset = drvdata->sig_offset;
        debug_regs[1].offset = drvdata->ver_offset;
@@ -74,22 +71,9 @@ int cc_debugfs_init(struct cc_drvdata *drvdata)
        regset->base = drvdata->cc_base;
 
        ctx->dir = debugfs_create_dir(drvdata->plat_dev->name, cc_debugfs_dir);
-       if (!ctx->dir)
-               return -ENFILE;
-
-       file = debugfs_create_regset32("regs", 0400, ctx->dir, regset);
-       if (!file) {
-               debugfs_remove(ctx->dir);
-               return -ENFILE;
-       }
 
-       file = debugfs_create_bool("coherent", 0400, ctx->dir,
-                                  &drvdata->coherent);
-
-       if (!file) {
-               debugfs_remove_recursive(ctx->dir);
-               return -ENFILE;
-       }
+       debugfs_create_regset32("regs", 0400, ctx->dir, regset);
+       debugfs_create_bool("coherent", 0400, ctx->dir, &drvdata->coherent);
 
        drvdata->debugfs = ctx;
 

diff --git a/drivers/crypto/ccree/cc_debugfs.h b/drivers/crypto/ccree/cc_debugfs.h
index 5b5320eca7d2e66e588701b08b7f58050319a2d5..01cbd9a956591a0e312d83e48cb38f9601a5698e 100644 (file)
--- a/drivers/crypto/ccree/cc_debugfs.h
+++ b/drivers/crypto/ccree/cc_debugfs.h
@@ -5,7 +5,7 @@
 #define __CC_DEBUGFS_H__
 
 #ifdef CONFIG_DEBUG_FS
-int cc_debugfs_global_init(void);
+void cc_debugfs_global_init(void);
 void cc_debugfs_global_fini(void);
 
 int cc_debugfs_init(struct cc_drvdata *drvdata);
@@ -13,11 +13,7 @@ void cc_debugfs_fini(struct cc_drvdata *drvdata);
 
 #else
 
-static inline int cc_debugfs_global_init(void)
-{
-       return 0;
-}
-
+static inline void cc_debugfs_global_init(void) {}
 static inline void cc_debugfs_global_fini(void) {}
 
 static inline int cc_debugfs_init(struct cc_drvdata *drvdata)

diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
index e75fbe7a8f84e4db5b65a0a03e54ecf1fc2d1f02..210cc86605e909dd918c1c7c38e3d7b112daa2e9 100644 (file)
--- a/drivers/crypto/ccree/cc_driver.c
+++ b/drivers/crypto/ccree/cc_driver.c
@@ -538,13 +538,8 @@ static struct platform_driver ccree_driver = {
 
 static int __init ccree_init(void)
 {
-       int ret;
-
        cc_hash_global_init();
-
-       ret = cc_debugfs_global_init();
-       if (ret)
-               return ret;
+       cc_debugfs_global_init();
 
        return platform_driver_register(&ccree_driver);
 }