SCSI: Fix Standard INQUIRY data

Vendor identification, product identification and product revision level
should be padded with spaces without a terminating NULL character, see
SCSI-2 standard, 8.2.5.1 Standard INQUIRY data.

Signed-off-by: Laszlo Ast <laszlo.ast@siemens-enterprise.com>
Signed-off-by: Jan Kiszka <jan.kiszka@siemens.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>

diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 67e3008980fcd636dc33681d837263d1654181fe..642d7919ba47acadc66f816b69428245a6e085ef 100644 (file)
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -424,12 +424,12 @@ static int scsi_disk_emulate_inquiry(SCSIRequest *req, uint8_t *outbuf)
     if (bdrv_get_type_hint(bdrv) == BDRV_TYPE_CDROM) {
         outbuf[0] = 5;
         outbuf[1] = 0x80;
-        memcpy(&outbuf[16], "QEMU CD-ROM    ", 16);
+        memcpy(&outbuf[16], "QEMU CD-ROM     ", 16);
     } else {
         outbuf[0] = 0;
-        memcpy(&outbuf[16], "QEMU HARDDISK  ", 16);
+        memcpy(&outbuf[16], "QEMU HARDDISK   ", 16);
     }
-    memcpy(&outbuf[8], "QEMU   ", 8);
+    memcpy(&outbuf[8], "QEMU    ", 8);
     memcpy(&outbuf[32], QEMU_VERSION, 4);
     /* Identify device as SCSI-3 rev 1.
        Some later commands are also implemented. */