]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
mm: workingset: simplify lockdep check in update_node
authorPedro Falcato <pfalcato@suse.de>
Mon, 21 Apr 2025 17:16:28 +0000 (18:16 +0100)
committerAndrew Morton <akpm@linux-foundation.org>
Tue, 13 May 2025 06:50:44 +0000 (23:50 -0700)
container_of(node->array, ..., i_pages) just to access i_pages again is an
incredibly roundabout way of accessing node->array itself.  Simplify it.

Link: https://lkml.kernel.org/r/20250421-workingset-simplify-v1-1-de5c40051e0e@suse.de
Signed-off-by: Pedro Falcato <pfalcato@suse.de>
Reviewed-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
mm/workingset.c

index 4841ae8af41113797378846f08336cd7c5757bd5..6e7f4cb1b9a7807e9288955f180a5b6cffab1a40 100644 (file)
@@ -612,7 +612,6 @@ struct list_lru shadow_nodes;
 
 void workingset_update_node(struct xa_node *node)
 {
-       struct address_space *mapping;
        struct page *page = virt_to_page(node);
 
        /*
@@ -623,8 +622,7 @@ void workingset_update_node(struct xa_node *node)
         * already where they should be. The list_empty() test is safe
         * as node->private_list is protected by the i_pages lock.
         */
-       mapping = container_of(node->array, struct address_space, i_pages);
-       lockdep_assert_held(&mapping->i_pages.xa_lock);
+       lockdep_assert_held(&node->array->xa_lock);
 
        if (node->count && node->count == node->nr_values) {
                if (list_empty(&node->private_list)) {