]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
hw/s390/ccw.c: Don't take address of packed members
authorPeter Maydell <peter.maydell@linaro.org>
Thu, 13 Dec 2018 12:02:52 +0000 (12:02 +0000)
committerCornelia Huck <cohuck@redhat.com>
Thu, 20 Dec 2018 16:07:24 +0000 (17:07 +0100)
Taking the address of a field in a packed struct is a bad idea, because
it might not be actually aligned enough for that pointer type (and
thus cause a crash on dereference on some host architectures). Newer
versions of clang warn about this.

Avoid the problem by using local copies of the PMCW and SCSW
struct fields in copy_schib_from_guest() and copy_schib_to_guest().

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Message-Id: <20181213120252.21697-1-peter.maydell@linaro.org>
Reviewed-by: Farhan Ali <alifm@linux.ibm.com>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>

No differences found