core/service: do not honor SuccessExitStatus= for our own helpers

They're exclusively under our control, hence errors should not be
suppressed based on external user input.

diff --git a/src/core/service.c b/src/core/service.c
index 7098e2744a9369df45f70b918c98f8daed1b8443..99dd7bd0da3c814697a662ba140e902260a9e099 100644 (file)
--- a/src/core/service.c
+++ b/src/core/service.c
@@ -4116,7 +4116,8 @@ static void service_sigchld_event(Unit *u, pid_t pid, int code, int status) {
         else
                 clean_mode = EXIT_CLEAN_DAEMON;
 
-        if (is_clean_exit(code, status, clean_mode, &s->success_status))
+        /* Our own helper processes are not subject to SuccessExitStatus= as they're opaque to users */
+        if (is_clean_exit(code, status, clean_mode, s->control_pid.pid == pid && s->control_command_id < 0 ? NULL : &s->success_status))
                 f = SERVICE_SUCCESS;
         else if (code == CLD_EXITED)
                 f = SERVICE_FAILURE_EXIT_CODE;