]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
i2c: rtl9300: introduce F_BUSY to the reg_fields struct
authorRustam Adilov <adilov@disroot.org>
Wed, 1 Apr 2026 18:06:43 +0000 (23:06 +0500)
committerAndi Shyti <andi.shyti@kernel.org>
Wed, 1 Apr 2026 22:09:11 +0000 (00:09 +0200)
In RTL9607C i2c controller the busy check operation is done on the
separate bit of the command register as opposed to self clearing
command trigger bit on the rtl9300 and rtl9310 i2c controllers.

Introduce a new F_BUSY field to the reg_fields struct for that
and change the regmap read poll function to use F_BUSY
instead of I2C_TRIG.

Signed-off-by: Rustam Adilov <adilov@disroot.org>
Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>
Signed-off-by: Andi Shyti <andi.shyti@kernel.org>
Link: https://lore.kernel.org/r/20260401180648.337834-4-adilov@disroot.org
drivers/i2c/busses/i2c-rtl9300.c

index 2cada6038b44f06cb1d9446bd6c5851f8e3ea494..e40b4692a3fa7b75c4223e6dceee202579a03869 100644 (file)
@@ -53,6 +53,7 @@ enum rtl9300_i2c_reg_fields {
        F_SCL_SEL,
        F_SDA_OUT_SEL,
        F_SDA_SEL,
+       F_BUSY,
 
        /* keep last */
        F_NUM_FIELDS
@@ -262,7 +263,7 @@ static int rtl9300_i2c_do_xfer(struct rtl9300_i2c *i2c, struct rtl9300_i2c_xfer
        if (ret)
                return ret;
 
-       ret = regmap_field_read_poll_timeout(i2c->fields[F_I2C_TRIG], val, !val, 100, 100000);
+       ret = regmap_field_read_poll_timeout(i2c->fields[F_BUSY], val, !val, 100, 100000);
        if (ret)
                return ret;
 
@@ -505,6 +506,7 @@ static const struct rtl9300_i2c_drv_data rtl9300_i2c_drv_data = {
                [F_MEM_ADDR_WIDTH]      = MST_REG_FIELD(RTL9300_I2C_MST_CTRL2, 2, 3),
                [F_SCL_FREQ]            = MST_REG_FIELD(RTL9300_I2C_MST_CTRL2, 0, 1),
                [F_SDA_SEL]             = GLB_REG_FIELD(RTL9300_I2C_MST_GLB_CTRL, 0, 7),
+               [F_BUSY]                = MST_REG_FIELD(RTL9300_I2C_MST_CTRL1, 0, 0),
        },
        .select_scl = rtl9300_i2c_select_scl,
        .rd_reg = RTL9300_I2C_MST_DATA_WORD0,
@@ -527,6 +529,7 @@ static const struct rtl9300_i2c_drv_data rtl9310_i2c_drv_data = {
                [F_I2C_FAIL]            = MST_REG_FIELD(RTL9310_I2C_MST_CTRL, 1, 1),
                [F_I2C_TRIG]            = MST_REG_FIELD(RTL9310_I2C_MST_CTRL, 0, 0),
                [F_MEM_ADDR]            = MST_REG_FIELD(RTL9310_I2C_MST_MEMADDR_CTRL, 0, 23),
+               [F_BUSY]                = MST_REG_FIELD(RTL9310_I2C_MST_CTRL, 0, 0),
        },
        .select_scl = rtl9310_i2c_select_scl,
        .rd_reg = RTL9310_I2C_MST_DATA_CTRL,