Fix up some nits

Reviewed-by: Matt Caswell <matt@openssl.org>
Reviewed-by: Tomas Mraz <tomas@openssl.org>
Reviewed-by: Saša Nedvědický <sashan@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/26361)

diff --git a/include/internal/quic_port.h b/include/internal/quic_port.h
index faad3357a2d457e783b9489c8a66e9cde81862ba..6dda25db84ff15c245763459eb034892b5498f92 100644 (file)
--- a/include/internal/quic_port.h
+++ b/include/internal/quic_port.h
@@ -44,7 +44,7 @@ typedef struct quic_port_args_st {
 
     /*
      * This callback allows port_new_handshake_layer to pre-create a quic
-     * connection object for the incomming channel
+     * connection object for the incoming channel
      * user_ssl_arg is expected to point to a quic listener object
      */
     SSL *(*get_conn_user_ssl)(QUIC_CHANNEL *ch, void *arg);

diff --git a/ssl/quic/quic_impl.c b/ssl/quic/quic_impl.c
index cade45de441e753f9691895805e9f3bd479e3ec5..0abc13126cbb35944d9c05700a58457ceedb8633 100644 (file)
--- a/ssl/quic/quic_impl.c
+++ b/ssl/quic/quic_impl.c
@@ -4600,7 +4600,6 @@ static QUIC_CONNECTION *create_qc_from_incoming_conn(QUIC_LISTENER *ql, QUIC_CHA
     }
 
     ossl_quic_channel_get_peer_addr(ch, &qc->init_peer_addr); /* best effort */
-    qc->listener                = NULL;
     qc->pending                 = 1;
     qc->engine                  = ql->engine;
     qc->port                    = ql->port;

diff --git a/ssl/quic/quic_port.c b/ssl/quic/quic_port.c
index 01dfbb84ef09f9c0cdc7f4c07a13310d04b168c1..1a4e1780d07fc50a2664c9f1f287b28a99dfcde0 100644 (file)
--- a/ssl/quic/quic_port.c
+++ b/ssl/quic/quic_port.c
@@ -479,7 +479,8 @@ static SSL *port_new_handshake_layer(QUIC_PORT *port, QUIC_CHANNEL *ch)
                                                   ql->obj.ssl.ctx->new_pending_conn_arg)) {
             SSL_free(tls);
             SSL_free(user_ssl);
-            qc->tls = NULL;
+            if (qc != NULL)
+                qc->tls = NULL;
             return NULL;
         }