]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
[mod_avmd] coverity CID 1395555 (Dereference before null check) 2054/head
authorDragos Oancea <dragos@signalwire.com>
Mon, 10 Apr 2023 15:15:42 +0000 (18:15 +0300)
committerDragos Oancea <dragos@signalwire.com>
Tue, 18 Apr 2023 09:58:16 +0000 (12:58 +0300)
src/mod/applications/mod_avmd/mod_avmd.c

index 6c59256eda992a416e574c33c9e06f97a11a58b4..e5076c15008b5ee4117c8944a684887483001b33 100644 (file)
@@ -1138,6 +1138,13 @@ SWITCH_MODULE_LOAD_FUNCTION(mod_avmd_load) {
 
        switch_application_interface_t *app_interface;
        switch_api_interface_t *api_interface;
+
+       if (pool == NULL) {
+               switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "No memory pool assigned!\n");
+
+               return SWITCH_STATUS_TERM;
+       }
+
        /* connect my internal structure to the blank pointer passed to me */
        *module_interface = switch_loadable_module_create_module_interface(pool, modname);
 
@@ -1147,10 +1154,6 @@ SWITCH_MODULE_LOAD_FUNCTION(mod_avmd_load) {
        }
 
        memset(&avmd_globals, 0, sizeof(avmd_globals));
-       if (pool == NULL) {
-               switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "No memory pool assigned!\n");
-               return SWITCH_STATUS_TERM;
-       }
        switch_mutex_init(&avmd_globals.mutex, SWITCH_MUTEX_NESTED, pool);
        avmd_globals.pool = pool;