BUG/MINOR: proxy: Missing calloc return value check in proxy_parse_declare

A memory allocation failure happening during proxy_parse_declare while
processing the "capture" keyword and allocating a cap_hdr structure
would have resulted in a crash. This function is only called during
configuration parsing.

It was raised in GitHub issue #1233.
It could be backported to all stable branches.

diff --git a/src/proxy.c b/src/proxy.c
index ce60df0bd2d87fa49978835e7c17034eddaa6552..079280c9c1d0b379ac62f852aace3eaf5c8ee76c 100644 (file)
--- a/src/proxy.c
+++ b/src/proxy.c
@@ -756,6 +756,10 @@ static int proxy_parse_declare(char **args, int section, struct proxy *curpx,
 
                /* register the capture. */
                hdr = calloc(1, sizeof(*hdr));
+               if (!hdr) {
+                       memprintf(err, "proxy '%s': out of memory while registering a capture", curpx->id);
+                       return -1;
+               }
                hdr->name = NULL; /* not a header capture */
                hdr->namelen = 0;
                hdr->len = len;