]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: rcar-gen4: Make read-only const array check_addr static
authorColin Ian King <colin.i.king@gmail.com>
Thu, 22 Aug 2024 20:59:41 +0000 (21:59 +0100)
committerKrzysztof Wilczyński <kwilczynski@kernel.org>
Sun, 1 Sep 2024 17:31:04 +0000 (17:31 +0000)
Don't populate the const read-only array check_addr on the stack at
run time, instead make it static.

Link: https://lore.kernel.org/linux-pci/20240822205941.643187-1-colin.i.king@gmail.com
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
[kwilczynski: refactor array definition]
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
drivers/pci/controller/dwc/pcie-rcar-gen4.c

index f0f3ebd1a033eb388deb7344794caf2d2e3a6d98..7d18853a46deea6f71ee06115a042b24bab4b37f 100644 (file)
@@ -606,7 +606,12 @@ static int rcar_gen4_pcie_reg_test_bit(struct rcar_gen4_pcie *rcar,
 static int rcar_gen4_pcie_download_phy_firmware(struct rcar_gen4_pcie *rcar)
 {
        /* The check_addr values are magical numbers in the datasheet */
-       const u32 check_addr[] = { 0x00101018, 0x00101118, 0x00101021, 0x00101121};
+       static const u32 check_addr[] = {
+               0x00101018,
+               0x00101118,
+               0x00101021,
+               0x00101121,
+       };
        struct dw_pcie *dw = &rcar->dw;
        const struct firmware *fw;
        unsigned int i, timeout;