]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
dfs_cache: fix a wrong use of kfree in flush_cache_ent()
authorGen Zhang <blackgod016574@gmail.com>
Tue, 28 May 2019 01:12:39 +0000 (09:12 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Jun 2019 06:09:12 +0000 (08:09 +0200)
[ Upstream commit 50fbc13dc12666f3604dc2555a47fc8c4e29162b ]

In flush_cache_ent(), 'ce->ce_path' is allocated by kstrdup_const().
It should be freed by kfree_const(), rather than kfree().

Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
Reviewed-by: Paulo Alcantara <palcantara@suse.de>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/cifs/dfs_cache.c

index 09b7d0d4f6e4fe5f6708d6387f6507ee20f6482f..007cfa39be5fbd6d4aebffefb7e3f64dccf9eb3b 100644 (file)
@@ -131,7 +131,7 @@ static inline void flush_cache_ent(struct dfs_cache_entry *ce)
                return;
 
        hlist_del_init_rcu(&ce->ce_hlist);
-       kfree(ce->ce_path);
+       kfree_const(ce->ce_path);
        free_tgts(ce);
        dfs_cache_count--;
        call_rcu(&ce->ce_rcu, free_cache_entry);
@@ -421,7 +421,7 @@ alloc_cache_entry(const char *path, const struct dfs_info3_param *refs,
 
        rc = copy_ref_data(refs, numrefs, ce, NULL);
        if (rc) {
-               kfree(ce->ce_path);
+               kfree_const(ce->ce_path);
                kmem_cache_free(dfs_cache_slab, ce);
                ce = ERR_PTR(rc);
        }