do not bypass hdrCacheInit() when there are no mime headers

diff --git a/src/HttpMsg.cc b/src/HttpMsg.cc
index b386244f2830913c5ac4a00b1875890feac5d600..d2aa351e219b7c8632be736b3438f3c5ac52e1db 100644 (file)
--- a/src/HttpMsg.cc
+++ b/src/HttpMsg.cc
@@ -287,20 +287,15 @@ HttpMsg::parseHeader(Http1::Parser &hp)
 {
     // HTTP/1 message contains "zero or more header fields"
     // zero does not need parsing
-    if (!hp.headerBlockSize()) {
-        pstate = psParsed;
-        return true;
-    }
-
     // XXX: c_str() reallocates. performance regression.
-    if (header.parse(hp.mimeHeader().c_str(), hp.headerBlockSize())) {
-        pstate = psParsed;
-        hdrCacheInit();
-        return true;
+    if (hp.headerBlockSize() && !header.parse(hp.mimeHeader().c_str(), hp.headerBlockSize())) {
+        pstate = psError;
+        return false;
     }
 
-    pstate = psError;
-    return false;
+    pstate = psParsed;
+    hdrCacheInit();
+    return true;
 }
 
 /* handy: resets and returns -1 */