]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/psr: Do not read PSR2_SU_STATUS on AlderLake and onwards
authorJouni Högander <jouni.hogander@intel.com>
Fri, 16 May 2025 06:30:19 +0000 (09:30 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Mon, 19 May 2025 06:45:47 +0000 (09:45 +0300)
Bspec comment on PSR2_SU_STATUS:

"This register has been tied-off since DG2/ADL-P (it returns zeros only)
and it has been removed on Xe2_LPD."

v2: fix inversed logic

Bspec: 69889
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Mika Kahola <mika.kahola@intel.com>
Link: https://lore.kernel.org/r/20250516063019.2126702-1-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_psr.c

index 430ad4ef714668bd59962f24a094b0df1a4ba651..cd833b63ea6b759ed365cbe315030348946720c8 100644 (file)
@@ -4021,24 +4021,30 @@ static int intel_psr_status(struct seq_file *m, struct intel_dp *intel_dp)
                int frame;
 
                /*
-                * Reading all 3 registers before hand to minimize crossing a
-                * frame boundary between register reads
+                * PSR2_SU_STATUS register has been tied-off since DG2/ADL-P
+                * (it returns zeros only) and it has been removed on Xe2_LPD.
                 */
-               for (frame = 0; frame < PSR2_SU_STATUS_FRAMES; frame += 3) {
-                       val = intel_de_read(display,
-                                           PSR2_SU_STATUS(display, cpu_transcoder, frame));
-                       su_frames_val[frame / 3] = val;
-               }
+               if (DISPLAY_VER(display) < 13) {
+                       /*
+                        * Reading all 3 registers before hand to minimize crossing a
+                        * frame boundary between register reads
+                        */
+                       for (frame = 0; frame < PSR2_SU_STATUS_FRAMES; frame += 3) {
+                               val = intel_de_read(display,
+                                                   PSR2_SU_STATUS(display, cpu_transcoder, frame));
+                               su_frames_val[frame / 3] = val;
+                       }
 
-               seq_puts(m, "Frame:\tPSR2 SU blocks:\n");
+                       seq_puts(m, "Frame:\tPSR2 SU blocks:\n");
 
-               for (frame = 0; frame < PSR2_SU_STATUS_FRAMES; frame++) {
-                       u32 su_blocks;
+                       for (frame = 0; frame < PSR2_SU_STATUS_FRAMES; frame++) {
+                               u32 su_blocks;
 
-                       su_blocks = su_frames_val[frame / 3] &
-                                   PSR2_SU_STATUS_MASK(frame);
-                       su_blocks = su_blocks >> PSR2_SU_STATUS_SHIFT(frame);
-                       seq_printf(m, "%d\t%d\n", frame, su_blocks);
+                               su_blocks = su_frames_val[frame / 3] &
+                                       PSR2_SU_STATUS_MASK(frame);
+                               su_blocks = su_blocks >> PSR2_SU_STATUS_SHIFT(frame);
+                               seq_printf(m, "%d\t%d\n", frame, su_blocks);
+                       }
                }
 
                seq_printf(m, "PSR2 selective fetch: %s\n",