]> git.ipfire.org Git - thirdparty/git.git/commitdiff
merge-ort: fix accidental strset<->strintmap
authorElijah Newren <newren@gmail.com>
Sun, 16 Mar 2025 06:58:58 +0000 (06:58 +0000)
committerJunio C Hamano <gitster@pobox.com>
Mon, 17 Mar 2025 22:39:03 +0000 (15:39 -0700)
Both strset_for_each_entry and strintmap_for_each_entry are macros that
evaluate to the same thing, so they are technically interchangeable.
However, the intent is that we use the one matching the variable type we
are passing.  Unfortunately, I somehow mistakenly got one of these wrong
in 7bee6c100431 (merge-ort: avoid recursing into directories when we
don't need to, 2021-07-16) -- possibly related to the fact that
relevant_sources was initially a strset and later refactored into a
strintmap.  Correct which macro we use.

Signed-off-by: Elijah Newren <newren@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
merge-ort.c

index 46e78c3ffa68e62dec08e8619800fcae28a9dd9d..a12aa213b06c0f4c154da8b529c7794918950f51 100644 (file)
@@ -1517,8 +1517,8 @@ static int handle_deferred_entries(struct merge_options *opt,
                struct strintmap copy;
 
                /* Loop over the set of paths we need to know rename info for */
-               strset_for_each_entry(&renames->relevant_sources[side],
-                                     &iter, entry) {
+               strintmap_for_each_entry(&renames->relevant_sources[side],
+                                        &iter, entry) {
                        char *rename_target, *dir, *dir_marker;
                        struct strmap_entry *e;