evaluate: expand sets and maps before evaluation

3975430b12d9 ("src: expand table command before evaluation") moved
ruleset expansion before evaluation, except for sets and maps. For
sets and maps there is still a post_expand() phase.

This patch moves sets and map expansion to allocate an independent
CMD_OBJ_SETELEMS command to add elements to named set and maps which is
evaluated, this consolidates the ruleset expansion to happen always
before the evaluation step for all objects, except for anonymous sets
and maps.

This approach avoids an interference with the set interval code which
detects overlaps and merges of adjacents ranges. This set interval
routine uses set->init to maintain a cache of existing elements. Then,
the post_expand() phase incorrectly expands set->init cache and it
triggers a bogus ENOENT errors due to incorrect bytecode (placing
element addition before set creation) in combination with user declared
sets using the flat syntax notation.

Since the evaluation step (coming after the expansion) creates
implicit/anonymous sets and maps, those are not expanded anymore. These
anonymous sets still need to be evaluated from set_evaluate() path and
the netlink bytecode generation path, ie. do_add_set(), needs to deal
with anonymous sets.

Note that, for named sets, do_add_set() does not use set->init. Such
content is part of the existing cache, and the CMD_OBJ_SETELEMS command
is responsible for adding elements to named sets.

Fixes: 3975430b12d9 ("src: expand table command before evaluation")
Reported-by: Jann Haber <jannh@selfnet.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>

diff --git a/src/cmd.c b/src/cmd.c
index 5e90fdcbd99a5c16dc3110bd1305958819e5559c..358dd1f9364e4ecb062ec283368483fd9c6e5048 100644 (file)
--- a/src/cmd.c
+++ b/src/cmd.c
@@ -402,21 +402,6 @@ void nft_cmd_expand(struct cmd *cmd)
                nft_cmd_expand_chain(chain, &new_cmds);
                list_splice(&new_cmds, &cmd->list);
                break;
-       default:
-               break;
-       }
-}
-
-void nft_cmd_post_expand(struct cmd *cmd)
-{
-       struct list_head new_cmds;
-       struct set *set;
-       struct cmd *new;
-       struct handle h;
-
-       init_list_head(&new_cmds);
-
-       switch (cmd->obj) {
        case CMD_OBJ_SET:
        case CMD_OBJ_MAP:
                set = cmd->set;

diff --git a/src/evaluate.c b/src/evaluate.c
index 90e7bff62cce55490b01a757e2a7e48cc589474f..a537dcfd52b34b95518e6bf3cce693a6b5a25bd7 100644 (file)
--- a/src/evaluate.c
+++ b/src/evaluate.c
@@ -4595,6 +4595,29 @@ static int set_expr_evaluate_concat(struct eval_ctx *ctx, struct expr **expr)
        return 0;
 }
 
+static int elems_evaluate(struct eval_ctx *ctx, struct set *set)
+{
+       ctx->set = set;
+       if (set->init != NULL) {
+               __expr_set_context(&ctx->ectx, set->key->dtype,
+                                  set->key->byteorder, set->key->len, 0);
+               if (expr_evaluate(ctx, &set->init) < 0)
+                       return -1;
+               if (set->init->etype != EXPR_SET)
+                       return expr_error(ctx->msgs, set->init, "Set %s: Unexpected initial type %s, missing { }?",
+                                         set->handle.set.name, expr_name(set->init));
+       }
+
+       if (set_is_interval(ctx->set->flags) &&
+           !(ctx->set->flags & NFT_SET_CONCAT) &&
+           interval_set_eval(ctx, ctx->set, set->init) < 0)
+               return -1;
+
+       ctx->set = NULL;
+
+       return 0;
+}
+
 static int set_evaluate(struct eval_ctx *ctx, struct set *set)
 {
        struct set *existing_set = NULL;
@@ -4693,23 +4716,6 @@ static int set_evaluate(struct eval_ctx *ctx, struct set *set)
        }
 
        set->existing_set = existing_set;
-       ctx->set = set;
-       if (set->init != NULL) {
-               __expr_set_context(&ctx->ectx, set->key->dtype,
-                                  set->key->byteorder, set->key->len, 0);
-               if (expr_evaluate(ctx, &set->init) < 0)
-                       return -1;
-               if (set->init->etype != EXPR_SET)
-                       return expr_error(ctx->msgs, set->init, "Set %s: Unexpected initial type %s, missing { }?",
-                                         set->handle.set.name, expr_name(set->init));
-       }
-
-       if (set_is_interval(ctx->set->flags) &&
-           !(ctx->set->flags & NFT_SET_CONCAT) &&
-           interval_set_eval(ctx, ctx->set, set->init) < 0)
-               return -1;
-
-       ctx->set = NULL;
 
        return 0;
 }
@@ -5182,6 +5188,8 @@ static int cmd_evaluate_add(struct eval_ctx *ctx, struct cmd *cmd)
        case CMD_OBJ_SET:
                handle_merge(&cmd->set->handle, &cmd->handle);
                return set_evaluate(ctx, cmd->set);
+       case CMD_OBJ_SETELEMS:
+               return elems_evaluate(ctx, cmd->set);
        case CMD_OBJ_RULE:
                handle_merge(&cmd->rule->handle, &cmd->handle);
                return rule_evaluate(ctx, cmd->rule, cmd->op);

diff --git a/src/libnftables.c b/src/libnftables.c
index c5f5729409d1aa737db7414b021f82fe34965e3f..7d36577dbf5fc1240a50bb5cda104f8477ea742d 100644 (file)
--- a/src/libnftables.c
+++ b/src/libnftables.c
@@ -562,13 +562,6 @@ static int nft_evaluate(struct nft_ctx *nft, struct list_head *msgs,
        if (err < 0 || nft->state->nerrs)
                return -1;
 
-       list_for_each_entry(cmd, cmds, list) {
-               if (cmd->op != CMD_ADD)
-                       continue;
-
-               nft_cmd_post_expand(cmd);
-       }
-
        return 0;
 }
 

diff --git a/src/rule.c b/src/rule.c
index 1e9e6c1a92c20e2c135590a83224fc708583050f..faa12afb3a07e253d30ae780235488294b2c1eb4 100644 (file)
--- a/src/rule.c
+++ b/src/rule.c
@@ -1458,7 +1458,13 @@ static int do_add_set(struct netlink_ctx *ctx, struct cmd *cmd,
                        return -1;
        }
 
-       return mnl_nft_set_add(ctx, cmd, flags);
+       if (mnl_nft_set_add(ctx, cmd, flags) < 0)
+               return -1;
+
+       if (set_is_anonymous(set->flags))
+               return __do_add_elements(ctx, cmd, set, set->init, flags);
+
+       return 0;
 }
 
 static int do_command_add(struct netlink_ctx *ctx, struct cmd *cmd, bool excl)

diff --git a/tests/shell/testcases/sets/0073flat_interval_set b/tests/shell/testcases/sets/0073flat_interval_set
new file mode 100755 (executable)
index 0000000..0630595
--- /dev/null
+++ b/tests/shell/testcases/sets/0073flat_interval_set
@@ -0,0 +1,11 @@
+#!/bin/bash
+
+set -e
+
+EXPECTED="flush ruleset
+add table inet filter
+add map inet filter testmap { type ipv4_addr : counter; flags interval;}
+add counter inet filter TEST
+add element inet filter testmap { 192.168.0.0/24 : \"TEST\" }"
+
+$NFT -f - <<< "$EXPECTED"

diff --git a/tests/shell/testcases/sets/0074nested_interval_set b/tests/shell/testcases/sets/0074nested_interval_set
new file mode 100755 (executable)
index 0000000..e7f65fc
--- /dev/null
+++ b/tests/shell/testcases/sets/0074nested_interval_set
@@ -0,0 +1,6 @@
+#!/bin/bash
+
+set -e
+
+dumpfile=$(dirname $0)/dumps/$(basename $0).nft
+$NFT -f "$dumpfile"

diff --git a/tests/shell/testcases/sets/dumps/0073flat_interval_set.nft b/tests/shell/testcases/sets/dumps/0073flat_interval_set.nft
new file mode 100644 (file)
index 0000000..20f5374
--- /dev/null
+++ b/tests/shell/testcases/sets/dumps/0073flat_interval_set.nft
@@ -0,0 +1,11 @@
+table inet filter {
+       counter TEST {
+               packets 0 bytes 0
+       }
+
+       map testmap {
+               type ipv4_addr : counter
+               flags interval
+               elements = { 192.168.0.0/24 : "TEST" }
+       }
+}

diff --git a/tests/shell/testcases/sets/dumps/0074nested_interval_set.nft b/tests/shell/testcases/sets/dumps/0074nested_interval_set.nft
new file mode 100644 (file)
index 0000000..20f5374
--- /dev/null
+++ b/tests/shell/testcases/sets/dumps/0074nested_interval_set.nft
@@ -0,0 +1,11 @@
+table inet filter {
+       counter TEST {
+               packets 0 bytes 0
+       }
+
+       map testmap {
+               type ipv4_addr : counter
+               flags interval
+               elements = { 192.168.0.0/24 : "TEST" }
+       }
+}