]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
wifi: rtw89: fw: propagate error code from rtw89_h2c_tx()
authorPing-Ke Shih <pkshih@realtek.com>
Mon, 17 Feb 2025 06:43:06 +0000 (14:43 +0800)
committerPing-Ke Shih <pkshih@realtek.com>
Fri, 21 Feb 2025 01:50:56 +0000 (09:50 +0800)
The error code should be propagated to callers during downloading firmware
header and body. Remove unnecessary assignment of -1.

Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>
Link: https://patch.msgid.link/20250217064308.43559-4-pkshih@realtek.com
drivers/net/wireless/realtek/rtw89/fw.c

index 0a129476171a1aa6cc9d6d78f5b3349ced382277..e05034fbb898e219ae8bcf261d00a9d2be30c1fd 100644 (file)
@@ -1510,7 +1510,6 @@ static int __rtw89_fw_download_hdr(struct rtw89_dev *rtwdev,
        ret = rtw89_h2c_tx(rtwdev, skb, false);
        if (ret) {
                rtw89_err(rtwdev, "failed to send h2c\n");
-               ret = -1;
                goto fail;
        }
 
@@ -1597,7 +1596,6 @@ static int __rtw89_fw_download_main(struct rtw89_dev *rtwdev,
                ret = rtw89_h2c_tx(rtwdev, skb, true);
                if (ret) {
                        rtw89_err(rtwdev, "failed to send h2c\n");
-                       ret = -1;
                        goto fail;
                }