]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/panic: clean Clippy warning
authorMiguel Ojeda <ojeda@kernel.org>
Mon, 3 Mar 2025 09:32:42 +0000 (10:32 +0100)
committerJocelyn Falempe <jfalempe@redhat.com>
Mon, 10 Mar 2025 09:52:55 +0000 (10:52 +0100)
Clippy warns:

    error: manual implementation of an assign operation
       --> drivers/gpu/drm/drm_panic_qr.rs:418:25
        |
    418 |                         self.carry = self.carry % pow;
        |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.carry %= pow`
        |
        = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern

Thus clean it up.

Fixes: dbed4a797e00 ("drm/panic: Better binary encoding in QR code")
Signed-off-by: Miguel Ojeda <ojeda@kernel.org>
Reviewed-by: Alice Ryhl <aliceryhl@google.com>
Reviewed-by: Jocelyn Falempe <jfalempe@redhat.com>
Signed-off-by: Jocelyn Falempe <jfalempe@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20250303093242.1011790-1-ojeda@kernel.org
drivers/gpu/drm/drm_panic_qr.rs

index 62cb8a16248349a1a8906e6278b032af89435351..3b0dd59781d4d27aa651d56333770f3514701e60 100644 (file)
@@ -415,7 +415,7 @@ impl Iterator for SegmentIterator<'_> {
                         self.carry_len -= out_len;
                         let pow = u64::pow(10, self.carry_len as u32);
                         let out = (self.carry / pow) as u16;
-                        self.carry = self.carry % pow;
+                        self.carry %= pow;
                         Some((out, NUM_CHARS_BITS[out_len]))
                     }
                 }