Correct error message for row-level triggers with transition tables on partitioned...

"Triggers on partitioned tables cannot have transition tables." is
incorrect as we allow statement-level triggers on partitioned tables to
have transition tables.

This has been wrong since commit 86f575948; back-patch to v11 where that
commit came in.

Reviewed by Tom Lane.

Discussion: https://postgr.es/m/CAPmGK17gk4vXLzz2iG%2BG4LWRWCoVyam70nZ3OuGm1hMJwDrhcg%40mail.gmail.com

diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c
index 1b72984ca37a790103552f0731cb0fc609151a71..794bfe1f1496f7da019f1ac836e814114729de22 100644 (file)
--- a/src/backend/commands/trigger.c
+++ b/src/backend/commands/trigger.c
@@ -263,7 +263,7 @@ CreateTriggerFiringOn(CreateTrigStmt *stmt, const char *queryString,
                                                (errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
                                                 errmsg("\"%s\" is a partitioned table",
                                                                RelationGetRelationName(rel)),
-                                                errdetail("Triggers on partitioned tables cannot have transition tables.")));
+                                                errdetail("ROW triggers with transition tables are not supported on partitioned tables.")));
                }
        }
        else if (rel->rd_rel->relkind == RELKIND_VIEW)

diff --git a/src/test/regress/expected/triggers.out b/src/test/regress/expected/triggers.out
index be6132db696659250f72d9ca832515e9cfeb019c..79e5e4b3533629d48ccbf2f0fe1019c5f66e282d 100644 (file)
--- a/src/test/regress/expected/triggers.out
+++ b/src/test/regress/expected/triggers.out
@@ -2024,7 +2024,7 @@ create trigger failed after update on parted_trig
   referencing old table as old_table
   for each row execute procedure trigger_nothing();
 ERROR:  "parted_trig" is a partitioned table
-DETAIL:  Triggers on partitioned tables cannot have transition tables.
+DETAIL:  ROW triggers with transition tables are not supported on partitioned tables.
 drop table parted_trig;
 --
 -- Verify trigger creation for partitioned tables, and drop behavior