]> git.ipfire.org Git - thirdparty/haproxy.git/commitdiff
MINOR: quic: Useless test in qc_prep_pkts()
authorFrédéric Lécaille <flecaille@haproxy.com>
Wed, 29 Dec 2021 15:00:47 +0000 (16:00 +0100)
committerFrédéric Lécaille <flecaille@haproxy.com>
Tue, 4 Jan 2022 16:30:00 +0000 (17:30 +0100)
These tests were there to initiate PTO probing but they are not correct.
Furthermore they may break the PTO probing process and lead to useless packet
building.

src/xprt_quic.c

index 5dd977db2b12a6a9b7ae595d1b00b0df8d6860cb..ae32e82e0085fa4a3a40e749cc1b6872facd7030 100644 (file)
@@ -2497,8 +2497,7 @@ static int qc_prep_pkts(struct quic_conn *qc, struct qring *qr)
                         * select the next level.
                         */
                        if ((tel == QUIC_TLS_ENC_LEVEL_INITIAL || tel == QUIC_TLS_ENC_LEVEL_HANDSHAKE) &&
-                           (MT_LIST_ISEMPTY(&qel->pktns->tx.frms) ||
-                            (next_tel != QUIC_TLS_ENC_LEVEL_NONE && qc->els[next_tel].pktns->tx.in_flight))) {
+                           (MT_LIST_ISEMPTY(&qel->pktns->tx.frms))) {
                                /* If QUIC_TLS_ENC_LEVEL_HANDSHAKE was already reached let's try QUIC_TLS_ENC_LEVEL_APP */
                                if (tel == QUIC_TLS_ENC_LEVEL_HANDSHAKE && next_tel == tel)
                                        next_tel = QUIC_TLS_ENC_LEVEL_APP;