]> git.ipfire.org Git - thirdparty/freeswitch.git/commitdiff
FS-10270: [mod_conference] Regression in personal canvas -- from: f1d8685566bab20beab...
authorAnthony Minessale <anthm@freeswitch.org>
Wed, 26 Apr 2017 20:25:04 +0000 (15:25 -0500)
committerAnthony Minessale <anthm@freeswitch.org>
Wed, 26 Apr 2017 20:25:04 +0000 (15:25 -0500)
src/mod/applications/mod_conference/conference_api.c
src/mod/applications/mod_conference/conference_video.c

index 95dd7a29ef0476178030921f4634c7bd7cab6522..c85fa44dad61d867f7ea5b44625771d390dd86cf 100644 (file)
@@ -1304,6 +1304,8 @@ switch_status_t conference_api_sub_vid_personal(conference_obj_t *conference, sw
                on = switch_true(argv[2]);
                if (on) {
                        conference_utils_set_flag(conference, CFLAG_PERSONAL_CANVAS);
+                       conference->video_layout_group = "grid";
+                       conference_utils_set_flag(conference, CFLAG_REFRESH_LAYOUT);
                } else {
                        conference_utils_clear_flag(conference, CFLAG_PERSONAL_CANVAS);
                }
index 7430b7899ff44d37827c036bbebffab936ea07a0..ce69d3d8583bde91e35c6c923a823b0e43508f17 100644 (file)
@@ -1080,7 +1080,9 @@ void conference_video_layer_set_logo(conference_member_t *member, mcu_layer_t *l
        switch_img_free(&layer->logo_img);
 
        if (member->video_logo) {
+               switch_mutex_lock(member->flag_mutex);
                switch_img_copy(member->video_logo, &layer->logo_img);
+               switch_mutex_unlock(member->flag_mutex);
 
                if (layer->logo_img) {
                        layer->logo_pos = member->logo_pos;
@@ -1101,7 +1103,9 @@ void conference_member_set_logo(conference_member_t *member, const char *path)
        switch_img_position_t pos = POS_LEFT_TOP;
        switch_img_fit_t fit = SWITCH_FIT_SIZE;
 
+       switch_mutex_lock(member->flag_mutex);
        switch_img_free(&member->video_logo);
+       switch_mutex_unlock(member->flag_mutex);
 
        if (!path || !strcasecmp(path, "clear")) {
                return;
@@ -4652,7 +4656,7 @@ switch_status_t conference_video_thread_callback(switch_core_session_t *session,
 
                int canvas_id = member->canvas_id;
 
-               if (frame->img && (member->video_layer_id > -1) && canvas_id > -1 &&
+               if (frame->img && (((member->video_layer_id > -1) && canvas_id > -1) || member->canvas) &&
                        conference_utils_member_test_flag(member, MFLAG_CAN_BE_SEEN) &&
                        switch_queue_size(member->video_queue) < member->conference->video_fps.fps * 2 &&
                        !member->conference->canvases[canvas_id]->playing_video_file) {