]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
PCI: dwc: Fix potential truncation in dw_pcie_edma_irq_verify()
authorNiklas Cassel <cassel@kernel.org>
Sat, 4 Jan 2025 00:21:20 +0000 (01:21 +0100)
committerBjorn Helgaas <bhelgaas@google.com>
Sat, 18 Jan 2025 17:34:48 +0000 (11:34 -0600)
Increase the size of the string buffer to avoid potential truncation in
dw_pcie_edma_irq_verify().

This fixes the following build warning when compiling with W=1:

  drivers/pci/controller/dwc/pcie-designware.c: In function ‘dw_pcie_edma_detect’:
  drivers/pci/controller/dwc/pcie-designware.c:989:50: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size 3 [-Wformat-truncation=]
    989 |                 snprintf(name, sizeof(name), "dma%d", pci->edma.nr_irqs);
        |                                                  ^~

Link: https://lore.kernel.org/r/20250104002119.2681246-2-cassel@kernel.org
Signed-off-by: Niklas Cassel <cassel@kernel.org>
Signed-off-by: Krzysztof Wilczyński <kwilczynski@kernel.org>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/pci/controller/dwc/pcie-designware.c

index 6d6cbc8b5b2c67b111d7e08006a833abc34d46b7..61e2314ce4752940e4cea3ffea0a5aba403690e6 100644 (file)
@@ -970,7 +970,7 @@ static int dw_pcie_edma_irq_verify(struct dw_pcie *pci)
 {
        struct platform_device *pdev = to_platform_device(pci->dev);
        u16 ch_cnt = pci->edma.ll_wr_cnt + pci->edma.ll_rd_cnt;
-       char name[6];
+       char name[15];
        int ret;
 
        if (pci->edma.nr_irqs == 1)