]> git.ipfire.org Git - thirdparty/rrdtool-1.x.git/commitdiff
src/rrd_modify.c: fix Coverity CID#32426 Copy into fixed size buffer
authorMarek Schimara <Marek.Schimara@bull.net>
Tue, 14 Jun 2016 15:02:11 +0000 (17:02 +0200)
committerMarek Schimara <Marek.Schimara@bull.net>
Thu, 23 Jun 2016 14:32:32 +0000 (16:32 +0200)
        CWE-120 / https://cwe.mitre.org/data/definitions/120.html

src/rrd_modify.c

index a9970becc17da81e1da0622ce3a5c3accea31c05..86fc47b9a59067cd929f7bad31409844dd2460b0 100644 (file)
@@ -1224,7 +1224,7 @@ static int add_rras(const rrd_t *in, rrd_t *out, const int *ds_map,
     }
 
     if (require_version != NULL && atoi(require_version) < atoi(out->stat_head->version)) {
-        strcpy(out->stat_head->version, require_version);
+        strncpy(out->stat_head->version, require_version, 5);
     }
 
     if (last_rra_cnt < out->stat_head->rra_cnt) {