* include/grub/misc.h (grub_strncat): Fix the order of conditionals to

	avoid accessing beyond the array.

diff --git a/ChangeLog b/ChangeLog
index 1b7fd441198aacbf321a5a513fa0db2e4f1b4819..352c69c4ffaf0b22f26bc7de82fbae18569c68ca 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2011-11-09  Vladimir Serbinenko  <phcoder@gmail.com>
+
+       * include/grub/misc.h (grub_strncat): Fix the order of conditionals to
+       avoid accessing beyond the array.
+
 2011-11-09  Vladimir Serbinenko  <phcoder@gmail.com>
 
        * configure.ac: Add missing -mXX to TARGET_CPPFLAGS.

diff --git a/include/grub/misc.h b/include/grub/misc.h
index 5bc159e7d2d8813a57a8e40dd5d0404e59cc60a2..4e7d9077cf38f1ff900d857b9c8e6b184894ce6a 100644 (file)
--- a/include/grub/misc.h
+++ b/include/grub/misc.h
@@ -87,7 +87,7 @@ grub_strncat (char *dest, const char *src, int c)
   while (*p)
     p++;
 
-  while ((*p = *src) != '\0' && c--)
+  while (c-- && (*p = *src) != '\0')
     {
       p++;
       src++;