]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
media: renesas: fdp1: Drop unneeded v4l2_m2m_get_vq() NULL check
authorLaurent Pinchart <laurent.pinchart@ideasonboard.com>
Wed, 15 Oct 2025 07:53:40 +0000 (10:53 +0300)
committerHans Verkuil <hverkuil+cisco@kernel.org>
Fri, 17 Oct 2025 09:31:15 +0000 (11:31 +0200)
The v4l2_m2m_get_vq() function never returns NULL. The check was
probably intended to catch invalid format types, but that's not needed
as the V4L2 core picks the appropriate VIDIOC_G_FMT ioctl handler based
on the format type, so the type can't be incorrect. Drop the unneeded
return value check and, as the function has no side effect, the function
call as well.

Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
drivers/media/platform/renesas/rcar_fdp1.c

index e615c56083f13b183be5b44764f24894f7539838..3515601030eccefe3d979303893c93c85ab0a9b2 100644 (file)
@@ -1409,9 +1409,6 @@ static int fdp1_g_fmt(struct file *file, void *priv, struct v4l2_format *f)
        struct fdp1_ctx *ctx = file_to_ctx(file);
        struct fdp1_q_data *q_data;
 
-       if (!v4l2_m2m_get_vq(ctx->fh.m2m_ctx, f->type))
-               return -EINVAL;
-
        q_data = get_q_data(ctx, f->type);
        f->fmt.pix_mp = q_data->format;