]> git.ipfire.org Git - thirdparty/qemu.git/commitdiff
net: cadence_gem: Remove incorrect assert()
authorEdgar E. Iglesias <edgar.iglesias@xilinx.com>
Fri, 23 Nov 2018 13:54:50 +0000 (14:54 +0100)
committerPeter Maydell <peter.maydell@linaro.org>
Mon, 26 Nov 2018 13:41:42 +0000 (13:41 +0000)
Don't assert on RX descriptor settings when the receiver is
disabled. This fixes an issue with incoming packets on an
unused GEM.

Reported-by: mbilal <muhammad_bilal@mentor.com>
Signed-off-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
Message-id: 20181123135450.24829-2-edgar.iglesias@gmail.com
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
hw/net/cadence_gem.c

index d95cc27f58350a448fec2baac854a2c11b768d0d..7f63411430fcc5cced3412f88abc9a22978564ac 100644 (file)
@@ -979,7 +979,6 @@ static ssize_t gem_receive(NetClientState *nc, const uint8_t *buf, size_t size)
 
         /* Do nothing if receive is not enabled. */
         if (!gem_can_receive(nc)) {
-            assert(!first_desc);
             return -1;
         }