]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ASoC: SOF: ipc4-topology: Improve the information in prepare_copier prints
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Thu, 6 Feb 2025 09:28:28 +0000 (11:28 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 6 Feb 2025 11:25:44 +0000 (11:25 +0000)
It is useful to know the explicit type and if the copier (host/dai) is
configured to use ChainDMA or not and also the stream_tag for the host
copier.

Change the prints to carry more information for debugging purposes.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Liam Girdwood <liam.r.girdwood@intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Link: https://patch.msgid.link/20250206092828.7569-5-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/ipc4-topology.c

index 21e29bfd4b22c939c0b63527a5d5ba54ecb94683..a23f55ed569697fa4a2722fa6f1ca9ebf860b4f1 100644 (file)
@@ -1815,15 +1815,19 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
        bool single_output_bitdepth;
        int i;
 
-       dev_dbg(sdev->dev, "copier %s, type %d", swidget->widget->name, swidget->id);
-
        switch (swidget->id) {
        case snd_soc_dapm_aif_in:
        case snd_soc_dapm_aif_out:
        {
+               struct snd_sof_widget *pipe_widget = swidget->spipe->pipe_widget;
+               struct sof_ipc4_pipeline *pipeline = pipe_widget->private;
                struct sof_ipc4_gtw_attributes *gtw_attr;
-               struct snd_sof_widget *pipe_widget;
-               struct sof_ipc4_pipeline *pipeline;
+
+               dev_dbg(sdev->dev,
+                       "Host copier %s, type %d, ChainDMA: %s, stream_tag: %d\n",
+                       swidget->widget->name, swidget->id,
+                       str_yes_no(pipeline->use_chain_dma),
+                       platform_params->stream_tag);
 
                /* parse the deep buffer dma size */
                ret = sof_update_ipc_object(scomp, &deep_buffer_dma_ms,
@@ -1840,9 +1844,6 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
                copier_data = &ipc4_copier->data;
                available_fmt = &ipc4_copier->available_fmt;
 
-               pipe_widget = swidget->spipe->pipe_widget;
-               pipeline = pipe_widget->private;
-
                if (pipeline->use_chain_dma) {
                        u32 host_dma_id;
                        u32 fifo_size;
@@ -1896,6 +1897,10 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
                struct snd_sof_widget *pipe_widget = swidget->spipe->pipe_widget;
                struct sof_ipc4_pipeline *pipeline = pipe_widget->private;
 
+               dev_dbg(sdev->dev, "Dai copier %s, type %d, ChainDMA: %s\n",
+                       swidget->widget->name, swidget->id,
+                       str_yes_no(pipeline->use_chain_dma));
+
                if (pipeline->use_chain_dma)
                        return 0;
 
@@ -1929,6 +1934,9 @@ sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
        }
        case snd_soc_dapm_buffer:
        {
+               dev_dbg(sdev->dev, "Module copier %s, type %d\n",
+                       swidget->widget->name, swidget->id);
+
                ipc4_copier = (struct sof_ipc4_copier *)swidget->private;
                copier_data = &ipc4_copier->data;
                available_fmt = &ipc4_copier->available_fmt;