]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
Merge patch series "riscv: Improve KASAN coverage to fix unit tests"
authorPalmer Dabbelt <palmer@rivosinc.com>
Thu, 19 Sep 2024 08:10:44 +0000 (01:10 -0700)
committerPalmer Dabbelt <palmer@rivosinc.com>
Thu, 19 Sep 2024 08:10:44 +0000 (01:10 -0700)
Samuel Holland <samuel.holland@sifive.com> says:

This series fixes two areas where uninstrumented assembly routines
caused gaps in KASAN coverage on RISC-V, which were caught by KUnit
tests. The KASAN KUnit test suite passes after applying this series.

This series fixes the following test failures:
  # kasan_strings: EXPECTATION FAILED at mm/kasan/kasan_test.c:1520
  KASAN failure expected in "kasan_int_result = strcmp(ptr, "2")", but none occurred
  # kasan_strings: EXPECTATION FAILED at mm/kasan/kasan_test.c:1524
  KASAN failure expected in "kasan_int_result = strlen(ptr)", but none occurred
  not ok 60 kasan_strings
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1531
  KASAN failure expected in "set_bit(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1533
  KASAN failure expected in "clear_bit(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1535
  KASAN failure expected in "clear_bit_unlock(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1536
  KASAN failure expected in "__clear_bit_unlock(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1537
  KASAN failure expected in "change_bit(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1543
  KASAN failure expected in "test_and_set_bit(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1545
  KASAN failure expected in "test_and_set_bit_lock(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1546
  KASAN failure expected in "test_and_clear_bit(nr, addr)", but none occurred
  # kasan_bitops_generic: EXPECTATION FAILED at mm/kasan/kasan_test.c:1548
  KASAN failure expected in "test_and_change_bit(nr, addr)", but none occurred
  not ok 61 kasan_bitops_generic

Samuel Holland (2):
  riscv: Omit optimized string routines when using KASAN
  riscv: Enable bitops instrumentation

arch/riscv/include/asm/bitops.h | 43 ++++++++++++++++++---------------
 arch/riscv/include/asm/string.h |  2 ++
 arch/riscv/kernel/riscv_ksyms.c |  3 ---
 arch/riscv/lib/Makefile         |  2 ++
 arch/riscv/lib/strcmp.S         |  1 +
 arch/riscv/lib/strlen.S         |  1 +
 arch/riscv/lib/strncmp.S        |  1 +
 arch/riscv/purgatory/Makefile   |  2 ++
 8 files changed, 32 insertions(+), 23 deletions(-)

* b4-shazam-merge:
  riscv: Enable bitops instrumentation
  riscv: Omit optimized string routines when using KASAN

Link: https://lore.kernel.org/r/20240801033725.28816-1-samuel.holland@sifive.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
1  2 
arch/riscv/lib/strcmp.S
arch/riscv/lib/strncmp.S

index bc73325b2fd1dbe54710b21d382fd05af73ead01,542301a67a2ff7b4925a888ea6419dfe15e2f877..57a5c00662315d753dbb9daf6102200025f389cd
@@@ -120,4 -120,4 +120,5 @@@ strcmp_zbb
  .option pop
  #endif
  SYM_FUNC_END(strcmp)
 +SYM_FUNC_ALIAS(__pi_strcmp, strcmp)
+ EXPORT_SYMBOL(strcmp)
index b36325a57f6af8cde7db5f0b68e82acb5a23bcee,0f359ea2f55b292cca7d6edf4923cba42bfa98b0..7b2d0ff9ed6c7e9b987c2d0f2bb15832f2541676
@@@ -136,4 -136,4 +136,5 @@@ strncmp_zbb
  .option pop
  #endif
  SYM_FUNC_END(strncmp)
 +SYM_FUNC_ALIAS(__pi_strncmp, strncmp)
+ EXPORT_SYMBOL(strncmp)