]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
can: bittiming: apply NL_SET_ERR_MSG() to can_calc_bittiming()
authorVincent Mailhol <mailhol@kernel.org>
Wed, 26 Nov 2025 10:16:03 +0000 (11:16 +0100)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Wed, 26 Nov 2025 10:20:43 +0000 (11:20 +0100)
When CONFIG_CAN_CALC_BITTIMING is disabled, the can_calc_bittiming()
functions can not be used and the user needs to provide all the
bittiming parameters.

Currently, can_calc_bittiming() prints an error message to the kernel
log. Instead use NL_SET_ERR_MSG() to make it return the error message
through the netlink interface so that the user can directly see it.

Signed-off-by: Vincent Mailhol <mailhol@kernel.org>
Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://patch.msgid.link/20251126-canxl-v8-2-e7e3eb74f889@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
include/linux/can/bittiming.h

index d30816dd93c7082c774ca4c01ee42465cd042ca0..3926c78b22222963b076562ee65471b8d3b89c6a 100644 (file)
@@ -141,7 +141,7 @@ static inline int
 can_calc_bittiming(const struct net_device *dev, struct can_bittiming *bt,
                   const struct can_bittiming_const *btc, struct netlink_ext_ack *extack)
 {
-       netdev_err(dev, "bit-timing calculation not available\n");
+       NL_SET_ERR_MSG(extack, "bit-timing calculation not available\n");
        return -EINVAL;
 }