btrfs: send: remove btrfs_debug() calls

There are debugging prints for each emitted send command and other
related actions. This does not seem right as the number of commands can
be high and dumping that to the system log will likely hit some rate
limiting.  This should be done by trace points that are more lightweight
and can keep up with high frequency.

Signed-off-by: David Sterba <dsterba@suse.com>

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 36ad01e345772136ef151be7c6e6a57487632512..2891ec4056c65b55a393c85058c8e0654305f6c7 100644 (file)
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -816,11 +816,8 @@ static int send_cmd(struct send_ctx *sctx)
 static int send_rename(struct send_ctx *sctx,
                     struct fs_path *from, struct fs_path *to)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret;
 
-       btrfs_debug(fs_info, "send_rename %s -> %s", from->start, to->start);
-
        ret = begin_cmd(sctx, BTRFS_SEND_C_RENAME);
        if (ret < 0)
                return ret;
@@ -840,11 +837,8 @@ tlv_put_failure:
 static int send_link(struct send_ctx *sctx,
                     struct fs_path *path, struct fs_path *lnk)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret;
 
-       btrfs_debug(fs_info, "send_link %s -> %s", path->start, lnk->start);
-
        ret = begin_cmd(sctx, BTRFS_SEND_C_LINK);
        if (ret < 0)
                return ret;
@@ -863,11 +857,8 @@ tlv_put_failure:
  */
 static int send_unlink(struct send_ctx *sctx, struct fs_path *path)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret;
 
-       btrfs_debug(fs_info, "send_unlink %s", path->start);
-
        ret = begin_cmd(sctx, BTRFS_SEND_C_UNLINK);
        if (ret < 0)
                return ret;
@@ -885,11 +876,8 @@ tlv_put_failure:
  */
 static int send_rmdir(struct send_ctx *sctx, struct fs_path *path)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret;
 
-       btrfs_debug(fs_info, "send_rmdir %s", path->start);
-
        ret = begin_cmd(sctx, BTRFS_SEND_C_RMDIR);
        if (ret < 0)
                return ret;
@@ -1573,7 +1561,6 @@ static int find_extent_clone(struct send_ctx *sctx,
        struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret;
        int extent_type;
-       u64 logical;
        u64 disk_byte;
        u64 num_bytes;
        struct btrfs_file_extent_item *fi;
@@ -1604,7 +1591,6 @@ static int find_extent_clone(struct send_ctx *sctx,
 
        compressed = btrfs_file_extent_compression(eb, fi);
        num_bytes = btrfs_file_extent_num_bytes(eb, fi);
-       logical = disk_byte + btrfs_file_extent_offset(eb, fi);
 
        /*
         * Setup the clone roots.
@@ -1686,14 +1672,8 @@ static int find_extent_clone(struct send_ctx *sctx,
        }
        up_read(&fs_info->commit_root_sem);
 
-       btrfs_debug(fs_info,
-                   "find_extent_clone: data_offset=%llu, ino=%llu, num_bytes=%llu, logical=%llu",
-                   data_offset, ino, num_bytes, logical);
-
-       if (!backref_ctx.found) {
-               btrfs_debug(fs_info, "no clones found");
+       if (!backref_ctx.found)
                return -ENOENT;
-       }
 
        cur_clone_root = NULL;
        for (i = 0; i < sctx->clone_roots_cnt; i++) {
@@ -2631,12 +2611,9 @@ static void free_path_for_command(const struct send_ctx *sctx, struct fs_path *p
 
 static int send_truncate(struct send_ctx *sctx, u64 ino, u64 gen, u64 size)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p;
 
-       btrfs_debug(fs_info, "send_truncate %llu size=%llu", ino, size);
-
        p = get_path_for_command(sctx, ino, gen);
        if (IS_ERR(p))
                return PTR_ERR(p);
@@ -2658,12 +2635,9 @@ out:
 
 static int send_chmod(struct send_ctx *sctx, u64 ino, u64 gen, u64 mode)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p;
 
-       btrfs_debug(fs_info, "send_chmod %llu mode=%llu", ino, mode);
-
        p = get_path_for_command(sctx, ino, gen);
        if (IS_ERR(p))
                return PTR_ERR(p);
@@ -2685,15 +2659,12 @@ out:
 
 static int send_fileattr(struct send_ctx *sctx, u64 ino, u64 gen, u64 fileattr)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p;
 
        if (sctx->proto < 2)
                return 0;
 
-       btrfs_debug(fs_info, "send_fileattr %llu fileattr=%llu", ino, fileattr);
-
        p = get_path_for_command(sctx, ino, gen);
        if (IS_ERR(p))
                return PTR_ERR(p);
@@ -2715,13 +2686,9 @@ out:
 
 static int send_chown(struct send_ctx *sctx, u64 ino, u64 gen, u64 uid, u64 gid)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p;
 
-       btrfs_debug(fs_info, "send_chown %llu uid=%llu, gid=%llu",
-                   ino, uid, gid);
-
        p = get_path_for_command(sctx, ino, gen);
        if (IS_ERR(p))
                return PTR_ERR(p);
@@ -2744,7 +2711,6 @@ out:
 
 static int send_utimes(struct send_ctx *sctx, u64 ino, u64 gen)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p = NULL;
        struct btrfs_inode_item *ii;
@@ -2753,8 +2719,6 @@ static int send_utimes(struct send_ctx *sctx, u64 ino, u64 gen)
        struct btrfs_key key;
        int slot;
 
-       btrfs_debug(fs_info, "send_utimes %llu", ino);
-
        p = get_path_for_command(sctx, ino, gen);
        if (IS_ERR(p))
                return PTR_ERR(p);
@@ -2861,7 +2825,6 @@ static int trim_dir_utimes_cache(struct send_ctx *sctx)
  */
 static int send_create_inode(struct send_ctx *sctx, u64 ino)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p;
        int cmd;
@@ -2870,8 +2833,6 @@ static int send_create_inode(struct send_ctx *sctx, u64 ino)
        u64 mode;
        u64 rdev;
 
-       btrfs_debug(fs_info, "send_create_inode %llu", ino);
-
        p = fs_path_alloc();
        if (!p)
                return -ENOMEM;
@@ -4224,8 +4185,6 @@ static int process_recorded_refs(struct send_ctx *sctx, int *pending_move)
        bool orphanized_dir = false;
        bool orphanized_ancestor = false;
 
-       btrfs_debug(fs_info, "process_recorded_refs %llu", sctx->cur_ino);
-
        /*
         * This should never happen as the root dir always has the same ref
         * which is always '..'
@@ -5334,12 +5293,9 @@ static int put_file_data(struct send_ctx *sctx, u64 offset, u32 len)
  */
 static int send_write(struct send_ctx *sctx, u64 offset, u32 len)
 {
-       struct btrfs_fs_info *fs_info = sctx->send_root->fs_info;
        int ret = 0;
        struct fs_path *p;
 
-       btrfs_debug(fs_info, "send_write offset=%llu, len=%d", offset, len);
-
        p = get_cur_inode_path(sctx);
        if (IS_ERR(p))
                return PTR_ERR(p);
@@ -5372,11 +5328,6 @@ static int send_clone(struct send_ctx *sctx,
        struct fs_path *cur_inode_path;
        u64 gen;
 
-       btrfs_debug(sctx->send_root->fs_info,
-                   "send_clone offset=%llu, len=%d, clone_root=%llu, clone_inode=%llu, clone_offset=%llu",
-                   offset, len, btrfs_root_id(clone_root->root),
-                   clone_root->ino, clone_root->offset);
-
        cur_inode_path = get_cur_inode_path(sctx);
        if (IS_ERR(cur_inode_path))
                return PTR_ERR(cur_inode_path);