tpm_crb_ffa: Remove memset usage

Simplify initialization of `ffa_send_direct_data2` and
`ffa_send_direct_data` structures by using designated initializers
instead of `memset()` followed by field assignments, reducing code size
and improving readability.

Signed-off-by: Prachotan Bathi <prachotan.bathi@arm.com>
Suggested-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

diff --git a/drivers/char/tpm/tpm_crb_ffa.c b/drivers/char/tpm/tpm_crb_ffa.c
index a4e7fcfa223a54073962ca7aca199849f0c192a9..afa341946f4ed4c7487b433aac57c2d7637a4f6a 100644 (file)
--- a/drivers/char/tpm/tpm_crb_ffa.c
+++ b/drivers/char/tpm/tpm_crb_ffa.c
@@ -203,26 +203,21 @@ static int __tpm_crb_ffa_send_receive(unsigned long func_id,
        msg_ops = tpm_crb_ffa->ffa_dev->ops->msg_ops;
 
        if (ffa_partition_supports_direct_req2_recv(tpm_crb_ffa->ffa_dev)) {
-               memset(&tpm_crb_ffa->direct_msg_data2, 0x00,
-                      sizeof(struct ffa_send_direct_data2));
-
-               tpm_crb_ffa->direct_msg_data2.data[0] = func_id;
-               tpm_crb_ffa->direct_msg_data2.data[1] = a0;
-               tpm_crb_ffa->direct_msg_data2.data[2] = a1;
-               tpm_crb_ffa->direct_msg_data2.data[3] = a2;
+               tpm_crb_ffa->direct_msg_data2 = (struct ffa_send_direct_data2){
+                       .data = { func_id, a0, a1, a2 },
+               };
 
                ret = msg_ops->sync_send_receive2(tpm_crb_ffa->ffa_dev,
                                &tpm_crb_ffa->direct_msg_data2);
                if (!ret)
                        ret = tpm_crb_ffa_to_linux_errno(tpm_crb_ffa->direct_msg_data2.data[0]);
        } else {
-               memset(&tpm_crb_ffa->direct_msg_data, 0x00,
-                      sizeof(struct ffa_send_direct_data));
-
-               tpm_crb_ffa->direct_msg_data.data1 = func_id;
-               tpm_crb_ffa->direct_msg_data.data2 = a0;
-               tpm_crb_ffa->direct_msg_data.data3 = a1;
-               tpm_crb_ffa->direct_msg_data.data4 = a2;
+               tpm_crb_ffa->direct_msg_data = (struct ffa_send_direct_data){
+                       .data1 = func_id,
+                       .data2 = a0,
+                       .data3 = a1,
+                       .data4 = a2,
+               };
 
                ret = msg_ops->sync_send_receive(tpm_crb_ffa->ffa_dev,
                                &tpm_crb_ffa->direct_msg_data);