]> git.ipfire.org Git - people/ms/linux.git/commitdiff
audit: restore order of tty and ses fields in log output
authorRichard Guy Briggs <rgb@redhat.com>
Mon, 15 Jul 2013 14:23:11 +0000 (10:23 -0400)
committerJiri Slaby <jslaby@suse.cz>
Fri, 23 May 2014 07:39:14 +0000 (09:39 +0200)
commit 2f2ad1013322c8f6c40fc6dafdbd32442fa730ad upstream.

When being refactored from audit_log_start() to audit_log_task_info(), in
commit e23eb920 the tty and ses fields in the log output got transposed.
Restore to original order to avoid breaking search tools.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Eric Paris <eparis@redhat.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
kernel/audit.c

index 6def25f1b351140fa2258bb164eb284dde01445f..74ced93e57030391637e6882c1705af33bfd9e06 100644 (file)
@@ -1615,7 +1615,7 @@ void audit_log_task_info(struct audit_buffer *ab, struct task_struct *tsk)
        audit_log_format(ab,
                         " ppid=%ld pid=%d auid=%u uid=%u gid=%u"
                         " euid=%u suid=%u fsuid=%u"
-                        " egid=%u sgid=%u fsgid=%u ses=%u tty=%s",
+                        " egid=%u sgid=%u fsgid=%u tty=%s ses=%u",
                         sys_getppid(),
                         tsk->pid,
                         from_kuid(&init_user_ns, audit_get_loginuid(tsk)),
@@ -1627,7 +1627,7 @@ void audit_log_task_info(struct audit_buffer *ab, struct task_struct *tsk)
                         from_kgid(&init_user_ns, cred->egid),
                         from_kgid(&init_user_ns, cred->sgid),
                         from_kgid(&init_user_ns, cred->fsgid),
-                        audit_get_sessionid(tsk), tty);
+                        tty, audit_get_sessionid(tsk));
 
        get_task_comm(name, tsk);
        audit_log_format(ab, " comm=");